[Mlir-commits] [llvm] [mlir] [mlir python] Add nanobind support for standalone dialects. (PR #117922)
Maksim Levental
llvmlistbot at llvm.org
Mon Dec 2 11:29:00 PST 2024
makslevental wrote:
@hawkinsp basically looks good to me; two questions (one load bearing, one curiosity):
1. We currently (in the pybind impl) have `module_local` in lots of places. nanobind doesn't have `module_local` and instead uses `NB_DOMAIN` (which maybe works the [same](https://github.com/wjakob/nanobind/blob/master/include/nanobind/nb_defs.h#L190) [way](https://github.com/wjakob/nanobind/blob/master/src/nb_internals.cpp#L384-L385)???). Do we want to support that?
2. Do the added bazel functions work in OSS? Possibly the question is ill-posed because scanning through the bazel I don't see a problematic rule that I thought I remembered seeing (`pybind_extension`) but I'm actually asking on behalf of users like @j2kun who have had trouble using python bindings bazel infra for OSS projects.
https://github.com/llvm/llvm-project/pull/117922
More information about the Mlir-commits
mailing list