[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Fix bug in `UnresolvedMaterializationRewrite` rollback (PR #105949)
Markus Böck
llvmlistbot at llvm.org
Sat Aug 31 03:13:56 PDT 2024
https://github.com/zero9178 approved this pull request.
This seems fine to me, as in being a step in the right direction, but it doesn't seem guaranteed to me that the input operand was actually the operand that was originally mapped to the materilization:
https://github.com/llvm/llvm-project/blob/0b9a69b3beb03f0de9b3c699e9b32a7b61b3ca57/mlir/lib/Transforms/Utils/DialectConversion.cpp#L1155
That said, this seems to be more of a pre-existing issue to me.
https://github.com/llvm/llvm-project/pull/105949
More information about the Mlir-commits
mailing list