[Mlir-commits] [flang] [mlir] [MLIR][LLVM] Make DISubprogramAttr cyclic (PR #106571)

[Billy Zhu]

================
@@ -221,14 +222,14 @@ DICompositeTypeAttr::getRecSelf(DistinctAttr recId) {
 
 DIRecursiveTypeAttrInterface DISubprogramAttr::withRecId(DistinctAttr recId) {
   return DISubprogramAttr::get(
-      getContext(), getId(), recId, getCompileUnit(), getScope(), getName(),
-      getLinkageName(), getFile(), getLine(), getScopeLine(),
-      getSubprogramFlags(), getType(), getRetainedNodes());
+      getContext(), recId, /*isRecSelf=*/false, getId(), getCompileUnit(),
----------------
zyx-billy wrote:

minor nit, I think it's safer to also `getIsRecSelf()` here just in case some place called this on an existing rec-self instance to change the ID (technically they should just use `getRecSelf` but we don't check).

https://github.com/llvm/llvm-project/pull/106571