[Mlir-commits] [mlir] [mlir][spirv] Add a generic `convert-to-spirv` pass (PR #95942)

[llvmlistbot at llvm.org]

================
@@ -31,6 +31,18 @@ def ConvertToLLVMPass : Pass<"convert-to-llvm"> {
   ];
 }
 
+//===----------------------------------------------------------------------===//
+// ToSPIRV
+//===----------------------------------------------------------------------===//
+
+def ConvertToSPIRVPass : Pass<"convert-to-spirv"> {
+  let summary = "Convert to SPIR-V";
+  let description = [{
+    This is a generic pass to convert to SPIR-V.
----------------
MaheshRavishankar wrote:

> > I think timeline will depend on how much community involvement we get here.
> 
> In this case I would want to see this pass moved to the test folder: I'm not comfortable with monolithic passes alongside the rest of the transformations right now.

I think this pass is used by the runner. Can we have a test pass that is used by the vulkan runner?  Anyway, I think there is agreement that this is the expected end-state, and the issue is noted.

Separate but related: We need to spell out clearly what passes are for in MLIR. I personally dont care about passes in MLIR. They are all only for testing IMO, but that is not a view held by everyone. If we explicitly call out that passes in MLIR are only for testing, unless really it needs to be a pass (like canonicalization, CSE, DCE or whatever). 


https://github.com/llvm/llvm-project/pull/95942