[Mlir-commits] [mlir] [mlir] Add the ability to define dialect-specific location attrs. (PR #105584)

[Aman LaChapelle]

bzcheeseman wrote:

> OOC could you say more about what didn't fit in the hierachy? (e.g., file is just a reference, so folks have done things like `gpu://0/1`).

Yes! We have some locations that have things like code snippets, or other metadata that didn't make sense to encode in the filename.

> Did you consider FusedLoc's metadata?

Yes - we are currently using this, but the issue is that we have a single FileLineColLoc, wrapped with a FusedLoc, which has metadata on it that has other file/line/column information, plus code snippets/etc. and it just didn't make a ton of sense representationally to me. IMO it'd be cleaner to allow the user to provide a custom location that just happens to have a file/line/col location embedded rather than also attaching the connotation of FusedLoc.

https://github.com/llvm/llvm-project/pull/105584