[Mlir-commits] [mlir] [mlir][arith] Add more canonicalization and integration tests coverage (PR #92272)

[Mehdi Amini]

joker-eph wrote:

> Even then, we wouldn't be certain that the expected implementation is correct. 

Right, but that's "separation of concerns". It's all what unit-testing is about: we check for a component boundaries based on the expectation at these boundaries. 

> A complementary approach is to run the C code on some small examples 

Right, I understand, but as as I mentioned before: we just don't do that historically in how LLVM compiler tests is set up.

> It's interesting to compare against LLVM too, since I think this discussion would only come about in MLIR due to the extensive lowerings.

I personally don't see a different between the expand-math in MLIR and the same thing on LLVM IR though.


https://github.com/llvm/llvm-project/pull/92272