[Mlir-commits] [mlir] [mlir][arith] Add more canonicalization and integration tests coverage (PR #92272)
Mehdi Amini
llvmlistbot at llvm.org
Thu Aug 29 06:22:46 PDT 2024
joker-eph wrote:
> However, several of the bugs the tests cover are from lowering steps down to LLVM. To test the produced LLVM code, to the best of my knowledge, integration tests seem to be the way (comparing LLVM code directly, rather than executing them, would be a bit fragile imo)
I think this is where we differ: the main way of testing LLVM (and MLIR) is with unit-tests checking the lowering through IR matching, not integration tests. These are more exceptional.
https://github.com/llvm/llvm-project/pull/92272
More information about the Mlir-commits
mailing list