[Mlir-commits] [mlir] Reapply "[mlir] NFC: fix dependence of (Tensor|Linalg|MemRef|Complex) dialects on LLVM Dialect and LLVM Core in CMake build (#104832)" (PR #105703)
Matthias Springer
llvmlistbot at llvm.org
Wed Aug 28 13:36:20 PDT 2024
================
@@ -379,8 +378,8 @@ LogicalResult ForLowering::matchAndRewrite(ForOp forOp,
// llvm.loop_annotation attribute.
SmallVector<NamedAttribute> llvmAttrs;
llvm::copy_if(forOp->getAttrs(), std::back_inserter(llvmAttrs),
- [](auto attr) {
- return isa<LLVM::LLVMDialect>(attr.getValue().getDialect());
+ [](NamedAttribute attr) {
+ return attr.getValue().getDialect().getNamespace() == "llvm";
----------------
matthias-springer wrote:
Why is this needed? Can `MLIRSCFToControlFlow` depend on the LLVM dialect?
https://github.com/llvm/llvm-project/pull/105703
More information about the Mlir-commits
mailing list