[Mlir-commits] [mlir] e886374 - [mlir][Transforms][NFC] Dialect conversion: Remove redundant `ReplaceBlockArgRewrite` (#105963)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Aug 27 07:48:45 PDT 2024


Author: Matthias Springer
Date: 2024-08-27T07:48:37-07:00
New Revision: e8863748ba76462cdbfdcbd7bd99cadf392c01f4

URL: https://github.com/llvm/llvm-project/commit/e8863748ba76462cdbfdcbd7bd99cadf392c01f4
DIFF: https://github.com/llvm/llvm-project/commit/e8863748ba76462cdbfdcbd7bd99cadf392c01f4.diff

LOG: [mlir][Transforms][NFC] Dialect conversion: Remove redundant `ReplaceBlockArgRewrite` (#105963)

There was a redundant `appendRewrite<ReplaceBlockArgRewrite>(block,
origArg);` in `ConversionPatternRewriterImpl::applySignatureConversion`
that had no effect.

Added: 
    

Modified: 
    mlir/lib/Transforms/Utils/DialectConversion.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 4058ed39621198..cc9c9495e5155c 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1296,7 +1296,6 @@ Block *ConversionPatternRewriterImpl::applySignatureConversion(
         OpBuilder::InsertPoint(newBlock, newBlock->begin()), origArg.getLoc(),
         /*inputs=*/replArgs, origArgType, converter);
     mapping.map(origArg, argMat);
-    appendRewrite<ReplaceBlockArgRewrite>(block, origArg);
 
     Type legalOutputType;
     if (converter) {


        


More information about the Mlir-commits mailing list