[Mlir-commits] [mlir] [mlir][gpu] Pass GPU module to `TargetAttrInterface::createObject`. (PR #94910)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Tue Aug 27 07:25:24 PDT 2024


================
@@ -47,7 +47,8 @@ def GPUTargetAttrInterface : AttrInterface<"TargetAttrInterface"> {
         meant to be used for passing additional options that are not in the
         attribute.
       }], "::mlir::Attribute", "createObject",
-        (ins "const ::llvm::SmallVector<char, 0>&":$object,
+        (ins "::mlir::Operation*":$module,
+             "const ::llvm::SmallVector<char, 0>&":$object,
              "const ::mlir::gpu::TargetOptions&":$options)>
----------------
ftynse wrote:

```suggestion
        (ins "::mlir::Operation *":$module,
             "const ::llvm::SmallVector<char, 0> &":$object,
             "const ::mlir::gpu::TargetOptions &":$options)>
```

https://github.com/llvm/llvm-project/pull/94910


More information about the Mlir-commits mailing list