[Mlir-commits] [mlir] Moving CppEmitter to header file. (PR #106201)

[Marius Brehler]

https://github.com/marbre requested changes to this pull request.

It is intended that the emitter only accepts the EmitC dialect, even though a few exceptions still exist. This was discussed during upstreaming and it was concluded not to expose the internals of the emitter.

With the `emitc.verbatim` op, a forked emitter should not be needed, as unsupported ops can be converted to this op. Prior to that, a forked emitter was used within IREE, but we were able to replace it by switching to the `emitc.verbatim` op, see https://github.com/iree-org/iree/commit/c15b610542b538f468d7249a645be16a6def3c18. In general, there is room for improvement and further operations should be added to the dialect, but with the availability of the `emitc.verbatim` op most downstream projects shouldn't be blocked.
If there is something that cannot be achieved with the existing ops, including the `emitc.verbatim` op, please provide an example. I am not supportive of this particular change (as elaborated above) but we're are of course more than happy to accept contributions that improve the dialect!

With that said, you may want to look at the discussion we had around #84973. In particular allow me to point you to https://github.com/llvm/llvm-project/pull/84973#issuecomment-1994614905.

https://github.com/llvm/llvm-project/pull/106201