[Mlir-commits] [mlir] [MLIR][Tensor] Fix source/dest type check in UnPackOp canonicalize (PR #106094)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Aug 26 19:36:38 PDT 2024


================
@@ -4439,7 +4439,7 @@ LogicalResult UnPackOp::canonicalize(UnPackOp unPackOp,
                                      PatternRewriter &rewriter) {
   /// pack(unpack(x)) -> x
----------------
yifeizh2 wrote:

@MaheshRavishankar Hi, I am also curious about the notation here. The pattern here matches
```
%packed = tensor.pack %x .....
%unpacked = tensor.unpack %packed .....
```
Shall it be denoted as `unpack(pack(x))` instead of `pack(unpack(x))`?

https://github.com/llvm/llvm-project/pull/106094


More information about the Mlir-commits mailing list