[Mlir-commits] [mlir] [MLIR][DLTI] Enable types as keys in DLTI-query utils (PR #105995)

[Rolf Morel]

rolfmorel wrote:

I think there might be a misunderstanding here: only the erroring-out path has any string manipulation, and only when requested, i.e. all string manipulation is guarded by `emitError==true` checks.

The key comparison itself is delegated to the `query()` method of attributes that implement `DLTIQueryInterface`, e.g. see the following from #104595: https://github.com/llvm/llvm-project/blob/34a88bbc34870e43fc00a9fc39f9267c844ac207/mlir/include/mlir/Dialect/DLTI/DLTIAttrs.td#L147 Unless I am misunderstanding - e.g. due to the involvement of PointerUnion - this _does_ make use of pointer comparisons for equality checks.

If you are concerned about the amount of string manipulation on the error-reporting path, I am happy to discuss that. If there's consensus in favour of less string manipulation even if that means less informative error messages, this is something I can work with on.

https://github.com/llvm/llvm-project/pull/105995