[Mlir-commits] [mlir] [mlir][arith] Add more canonicalization and integration tests coverage (PR #92272)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Aug 26 12:02:47 PDT 2024


banach-space wrote:

Hi @joker-eph , thanks for the feedback. These are very good points and I agree - we should prioritise unit testing over e2e tests where possible.

I don't really have enough architectural overview of Arith to say whether _these_ particular tests fill a gap in our testing vs "working around lack of unit-testing right now". And I admit, when reviewing, I focus on the implementation details rather than the bigger picture. Input from folks with more experience with Arith would be greatly appreciated.

My overall steer for these e2e tests has been to keep them minimal and clearly structured so that we know exactly what is being tested. Once complete, we should probably audit them and make sure that similar functionality isn't already tested elsewhere (i.e. remove duplication). That shouldn't be too difficult give how cleanly @pingshiyu has organised them.

https://github.com/llvm/llvm-project/pull/92272


More information about the Mlir-commits mailing list