[Mlir-commits] [mlir] [MLIR][DLTI] Enable types as keys in DLTI-query utils (PR #105995)

Adam Siemieniuk llvmlistbot at llvm.org
Mon Aug 26 02:52:37 PDT 2024


================
@@ -424,8 +424,8 @@ getClosestQueryable(Operation *op) {
   return std::pair(queryable, op);
 }
 
-FailureOr<Attribute> dlti::query(Operation *op, ArrayRef<StringAttr> keys,
-                                 bool emitError) {
+FailureOr<Attribute>
+dlti::query(Operation *op, ArrayRef<DataLayoutEntryKey> keys, bool emitError) {
----------------
adam-smnk wrote:

Unrelated to this PR so feel free to ignore for now but just came to my mind.

What's the desired behavior when `keys` is empty? Right now it works but it's not covered by any test.

https://github.com/llvm/llvm-project/pull/105995


More information about the Mlir-commits mailing list