[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Remove redundant `ReplaceBlockArgRewrite` (PR #105963)

[Matthias Springer]

https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/105963

There was a redundant `appendRewrite<ReplaceBlockArgRewrite>(block, origArg);` in `ConversionPatternRewriterImpl::applySignatureConversion` that had no effect.

>From cd7786b814b6552e3abde01b8b3d0f6d0d70d9db Mon Sep 17 00:00:00 2001
From: Matthias Springer <mspringer at nvidia.com>
Date: Sun, 25 Aug 2024 01:27:11 +0200
Subject: [PATCH] [mlir][Transforms] Dialect conversion: Remove redundant
 `ReplaceBlockArgRewrite`

There was a redundant `appendRewrite<ReplaceBlockArgRewrite>(block, origArg);` in `ConversionPatternRewriterImpl::applySignatureConversion` that had no effect.
---
 mlir/lib/Transforms/Utils/DialectConversion.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 4058ed39621198..cc9c9495e5155c 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1296,7 +1296,6 @@ Block *ConversionPatternRewriterImpl::applySignatureConversion(
         OpBuilder::InsertPoint(newBlock, newBlock->begin()), origArg.getLoc(),
         /*inputs=*/replArgs, origArgType, converter);
     mapping.map(origArg, argMat);
-    appendRewrite<ReplaceBlockArgRewrite>(block, origArg);
 
     Type legalOutputType;
     if (converter) {