[Mlir-commits] [mlir] [mlir] Change `tensor.extract/insert` to take static/dynamic indices. (PR #104488)

[Matthias Springer]

matthias-springer wrote:

What do you think about `OpBuilder::createOrFold`? It currently returns `Value`, but I think it should return `OpFoldResult`. I tried to change that at some point (but it was too much work). As a follow-up, I wanted to update more tensors ops to store "mixed" values. (Similar to what this PR is doing.) Then the API would work nicely with `createOrFold`. (In a sense that the op builder can take the result of a `createOrFold` and does not have to build an op for a constant value.) But also, that never happened...

https://github.com/llvm/llvm-project/pull/104488