[Mlir-commits] [mlir] [mlir][EmitC] Model lvalues as a type in EmitC (PR #91475)

[Simon Camphausen]

simon-camp wrote:

> Maybe the `emitc.load` could be allowed inside the `emitc.expression`, since it doesn't do anything _useful_ on its own and more of a type-system level safety? Then `form-expressions` pass will likely deal with it correctly.

The `emitc.load` op models the side effect of reading the value. If this would be used inside an expression we wouldn't be able to ensure the correct semantics (i.e. ordering of multiple load ops), as the [order of evaluation](https://en.cppreference.com/w/c/language/eval_order) is unspecified in C.

But I'd like to hear opinions from @aniragil or @mgehre-amd.

https://github.com/llvm/llvm-project/pull/91475