[Mlir-commits] [llvm] [mlir] eliminating g++ warnings (PR #105520)

Jakub Kuderski llvmlistbot at llvm.org
Wed Aug 21 06:47:51 PDT 2024


================
@@ -1593,7 +1593,8 @@ foldTrait(Operation *, ArrayRef<Attribute>, SmallVectorImpl<OpFoldResult> &) {
 /// Given a tuple type containing a set of traits, return the result of folding
 /// the given operation.
 template <typename... Ts>
-static LogicalResult foldTraits(Operation *op, ArrayRef<Attribute> operands,
+static LogicalResult foldTraits([[maybe_unused]] Operation *op,
+                                [[maybe_unused]] ArrayRef<Attribute> operands,
----------------
kuhar wrote:

This and similar seem clearly used unless `sizeof...(Ts)` is 0. Would adding a static assert potentially fix that?
Otherwise the negative of declaring these as maybe unused has the downside that if they truly become unused at some point in the future,  we won't get that warning

https://github.com/llvm/llvm-project/pull/105520


More information about the Mlir-commits mailing list