[Mlir-commits] [mlir] [mlir][vector] Add more tests for ConvertVectorToLLVM (5/n) (PR #104784)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thank you! This is a great improvement as is, but perhaps it could be tweaked further?  See my inline suggestions.

In general, I suggest sticking to one format, e.g.

```mlir
@op-name_{scalar|vec}_from_vec{0d|1d|2d}_{res_elt_ty}_idx_as_{i32|index}
```

The actual format is secondary - consistency is more important IMHO. Also, no need to be super strict (ie in some cases you'd skip and/or rephrases some bits).

Hope this is helpful. I am typing on my phone - apologies for typos.

https://github.com/llvm/llvm-project/pull/104784