[Mlir-commits] [mlir] [mlir][gpu] Add extra value types for gpu::ShuffleOp (PR #104605)

[Jakub Kuderski]

kuhar wrote:

`AnyIntegerOrFloatOr1DVector` sounds good to me.

> I was trying to justify why I haven't implemented changes in the other conversions.

I think it makes a lot of sense to do a survey of what's supported down the lowering chains, but I would not expect changes to these conversions directly. Instead, if there was need/demands, we could provide expansion within the gpu dialect, similar to how we handle `gpu.subgroup_reduce` in https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp .

In the PR description:
> gpu-to-vulkan: currently doesn't lower the shuffle op

I'd change it to: `gpu-to-vulkan: not applicable`, or remove from the list.





https://github.com/llvm/llvm-project/pull/104605