[Mlir-commits] [mlir] [mlir][debug] Handle DIImportedEntity. (PR #103055)

Tobias Gysi llvmlistbot at llvm.org
Mon Aug 19 09:54:08 PDT 2024


================
@@ -316,7 +316,8 @@ MLIR_CAPI_EXPORTED MlirAttribute mlirLLVMDISubprogramAttrGet(
     MlirContext ctx, MlirAttribute id, MlirAttribute compileUnit,
     MlirAttribute scope, MlirAttribute name, MlirAttribute linkageName,
     MlirAttribute file, unsigned int line, unsigned int scopeLine,
-    uint64_t subprogramFlags, MlirAttribute type);
+    uint64_t subprogramFlags, MlirAttribute type, intptr_t nNodes,
+    MlirAttribute const *nodes);
----------------
gysit wrote:

```suggestion
    uint64_t subprogramFlags, MlirAttribute type, intptr_t nRetainedNodes,
    MlirAttribute const *retainedNodes);
```
nit: The name should probably match the attribute fields?

https://github.com/llvm/llvm-project/pull/103055


More information about the Mlir-commits mailing list