[Mlir-commits] [mlir] [mlir][gpu] Add extra value types for gpu::ShuffleOp (PR #104605)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Mon Aug 19 09:10:54 PDT 2024
FMarno wrote:
Thank you @kuhar for your review. Sorry if my language was a bit ambiguous/relax is the PR description, I was trying to justify why I haven't implemented changes in the other conversions. I will try to make that more clear.
I think I agree that it makes sense for the shuffle operation and the subgroup reduce operation to have the same restriction for the type of `$value` and would even be open to a less restrictive type, such as the `NVVM_ShflOp` which uses `LLVM_Type` for `$value`. Saying that, `AnyIntegerOrFloatOr1DVector` is more than enough for my use-case.
https://github.com/llvm/llvm-project/pull/104605
More information about the Mlir-commits
mailing list