[Mlir-commits] [mlir] [MLIR][MathDialect] fix fp32 promotion crash when encounters scf.if (PR #104451)

Ivy Zhang llvmlistbot at llvm.org
Mon Aug 19 05:41:01 PDT 2024


================
@@ -69,6 +70,7 @@ void mlir::math::populateLegalizeToF32ConversionTarget(
       [&typeConverter](Operation *op) -> bool {
         return typeConverter.isLegal(op);
       });
+  target.addLegalOp<scf::IfOp>();
----------------
crazydemo wrote:

I set all the `non-math` dialects as legal. Maybe Arith should be processed in `emulate-unsupported-floats`.

https://github.com/llvm/llvm-project/pull/104451


More information about the Mlir-commits mailing list