[Mlir-commits] [mlir] [mlir][docgen] Emit OpInterface for Operations within Dialect Doc (PR #104693)

[Tom Natan]

tomnatan30 wrote:

Thanks @ammar2199, I actually wasn't aware of -gen-op-interface-docs, sorry about that! I thought it would be nice to have the dialect doc also include all op interfaces defined in the dialect, maybe it's simply a matter of adding what is generated by -gen-op-interface-docs in the dialect doc. I personally don't think we should inlcude information on interfaces that aren't part of the dialect, because this doc serves as documentation for the IR of the dialect itself, and the user can always read the documentation of the relevant dialect. @jpienaar wdyt?

Also, worth updating the test file in mlir/test/mlir-tblgen/gen-dialect-doc.td with an op interface so we see the result of this change.

See https://github.com/llvm/llvm-project/pull/98885 for reference (added enum support)

https://github.com/llvm/llvm-project/pull/104693