[Mlir-commits] [mlir] [mlir] Change `tensor.extract/insert` to take static/dynamic indices. (PR #104488)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> What is the motivation for this?
> 
> In general I see this as an anti-pattern to have operation accept both an attribute and an SSA value.
> I thought the "experiment" with the few ops that adopted this form in the past was deemed like an accepted "bad idea" in the end?

I think there is a long history of discussion here, but for one I prefer the mixed static/dynamic list. It is pretty readable and constant values are folded into the operation itself instead have to lookup use-def chains.  So I would very much prefer having a general utility of the form being added in this PR. So +1 from me!

https://github.com/llvm/llvm-project/pull/104488