[Mlir-commits] [mlir] [mlir][spirv] Fix incorrect metadata in SPIR-V Header (PR #104242)

[Amr Hesham]

================
@@ -51,7 +51,7 @@ void spirv::appendModuleHeader(SmallVectorImpl<uint32_t> &header,
   // | 0 (reserved for instruction schema)                                     |
   // +-------------------------------------------------------------------------+
   header.push_back(spirv::kMagicNumber);
-  header.push_back((majorVersion << 16) | (minorVersion << 8));
+  header.push_back((majorVersion << 8) | minorVersion);
   header.push_back(kGeneratorNumber);
----------------
AmrDeveloper wrote:

So after SPIR-V version we should have "MLIR" as software generated then version number but version of MLIR (LLVM_VERSION_STRING) or you mean the kGeneratorNumber because in the docs it mention the "Generator’s magic number. It is associated with the tool that generated the module" so can you clear a bit "This last "generator" word also contains a version number"

Thank you

https://github.com/llvm/llvm-project/pull/104242