[Mlir-commits] [mlir] [MLIR][MathDialect] fix fp32 promotion crash when encounters scf.if (PR #104451)

Krzysztof Drewniak llvmlistbot at llvm.org
Fri Aug 16 09:23:00 PDT 2024


================
@@ -69,6 +70,7 @@ void mlir::math::populateLegalizeToF32ConversionTarget(
       [&typeConverter](Operation *op) -> bool {
         return typeConverter.isLegal(op);
       });
+  target.addLegalOp<scf::IfOp>();
----------------
krzysz00 wrote:

Could you instead make this "have all non-`math`, non-`arith`" dialects be legal?

https://github.com/llvm/llvm-project/pull/104451


More information about the Mlir-commits mailing list