[Mlir-commits] [mlir] [mlir][vector] Add more tests for ConvertVectorToLLVM (4/n) (PR #103391)

[Andrzej Warzyński]

banach-space wrote:

Ha, good points!

> Do you think we should rename tests on `vector.insert` to not have a name like `insert_element*` for more clarity ? like `@insert_vec_1d_into_vec_3d`.

+1

> We could imagine for example `@insert_element_into_vec_3d` to be renamed into `@insert_scalar_into_vec_3d`.

+1 

IMO, this would be most natural naming scheme: `@op-name_some_unique_features`. 

Basically, what you proposed there ^^^ :)

> Also, for the `insert_element_with_value*` tests. `with_value` means that the index is dynamic, I suppose ? How about ` @insert_element_with_value_1d` => ` @insert_scalar_into_vec_1d_dynamic_index`

I was thinking exactly the same :)

I am about to disappear for a week and would love to land this as is if that's OK with you. Would you be willing to send a PR to rename the tests? 

Thanks for taking a look 🙏🏻 

https://github.com/llvm/llvm-project/pull/103391