[Mlir-commits] [mlir] [mlir][linalg] Improve getPreservedProducerResults estimation in ElementwiseOpFusion (PR #104409)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Aug 15 14:15:51 PDT 2024


https://github.com/MaheshRavishankar commented:

Overall this makes sense. But I'll state the same caveat as the one that I said previously when this was added. Having such methods that are decoupled from the transformation itself are inherently fragile... The implementation could drift, or might not actually support the result of this analysis.
To preserve status quo, I am fine with the change here (please move the method out of `ElementwiseOpFusionResult` object), but please also add a note that says that there is a chance that the implementation of the transformation does not agree with the result of this method (unless there is a way to ensure that).

https://github.com/llvm/llvm-project/pull/104409


More information about the Mlir-commits mailing list