[Mlir-commits] [llvm] [mlir] Add missing dialects to C API (PR #82190)

[Benjamin Maxwell]

Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/82190 at github.com>


================
@@ -1,5 +1,7 @@
 set(LLVM_TARGET_DEFINITIONS Passes.td)
 mlir_tablegen(Passes.h.inc -gen-pass-decls -name EmitC)
+mlir_tablegen(Passes.capi.h.inc -gen-pass-capi-header --prefix EmitC)
+mlir_tablegen(Passes.capi.cpp.inc -gen-pass-capi-impl --prefix EmitC)
----------------
MacDue wrote:

It's building now, but it looks like the generated `Passes.capi.cpp.inc` implementation files are not actually being used.

>From looking at how it's done for other dialects, it looks like you still need to create a .cpp file, and include it:

https://github.com/llvm/llvm-project/blob/57abd4e4abb705a453134051743542de5fd396bc/mlir/lib/CAPI/Dialect/GPUPasses.cpp#L1-L26

https://github.com/llvm/llvm-project/pull/82190