[Mlir-commits] [mlir] [mlir][vector] Add more tests for ConvertVectorToLLVM (4/n) (PR #103391)

[Hugo Trachino]

https://github.com/nujaa commented:

Hi, I got a note for maybe another MR, 

> tests for vector.insertelement (tested by @insertelement{}) and
vector.insert (tested by @insert_element{}).
 Do you think we should rename tests on `vector.insert` to not have a name like `insert_element*` for more clarity ? like `@insert_vec_1d_into_vec_3d`.

We could imagine for example `@insert_element_into_vec_3d` to be renamed into `@insert_scalar_into_vec_3d`.  
Also, for the `insert_element_with_value*`  tests. `with_value` means that the index is dynamic, I suppose ?
How about ` @insert_element_with_value_1d` => ` @insert_scalar_into_vec_1d_dynamic_index`

https://github.com/llvm/llvm-project/pull/103391