[Mlir-commits] [mlir] [mlir][spirv] Fix incorrect metadata in SPIR-V Header (PR #104242)

[Andrea Faulds]

================
@@ -42,7 +42,7 @@ void spirv::appendModuleHeader(SmallVectorImpl<uint32_t> &header,
   // +-------------------------------------------------------------------------+
   // | Magic number                                                            |
   // +-------------------------------------------------------------------------+
-  // | Version number (bytes: 0 | major number | minor number | 0)             |
+  // | Version number (bytes: 0 | 0 | major number | minor number)             |
----------------
andfau-amd wrote:

This seems to contradict the text of the spec: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_physical_layout_of_a_spir_v_module_and_instruction (see section 2.3 "Physical Layout of a SPIR-V Module and Instruction")

Can you demonstrate that it's correct? For example, does `spirv-dis` agree with it?

https://github.com/llvm/llvm-project/pull/104242