[Mlir-commits] [llvm] [mlir] Add missing dialects to C API (PR #82190)

[Benjamin Maxwell]

Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/82190 at github.com>


================
@@ -1,7 +1,9 @@
 set(LLVM_TARGET_DEFINITIONS Passes.td)
 mlir_tablegen(Passes.h.inc -gen-pass-decls -name ArmSME)
-mlir_tablegen(PassesEnums.h.inc -gen-enum-decls)
-mlir_tablegen(PassesEnums.cpp.inc -gen-enum-defs)
+mlir_tablegen(Passes.capi.h.inc -gen-pass-capi-header --prefix ArmSME)
+mlir_tablegen(Passes.capi.cpp.inc -gen-pass-capi-impl --prefix ArmSME)
+mlir_tablegen(PassesEnums.h.inc -gen-enum-decls -gen-pass-capi-header --prefix ArmSME)
+mlir_tablegen(PassesEnums.cpp.inc -gen-enum-defs -gen-pass-capi-impl --prefix ArmSME)
 add_public_tablegen_target(MLIRArmSMETransformsIncGen)
 add_dependencies(mlir-headers MLIRArmSMETransformsIncGen)
 
----------------
MacDue wrote:

This is almost correct, the problem now is `PassesEnums.cpp/h.inc` are also being passed `-gen-pass-capi-impl --prefix ArmSME`. Which is preventing the enums from being generated. I think this should look like:

```
set(LLVM_TARGET_DEFINITIONS Passes.td)
mlir_tablegen(Passes.h.inc -gen-pass-decls -name ArmSME)
mlir_tablegen(Passes.capi.h.inc -gen-pass-capi-header --prefix ArmSME)
mlir_tablegen(Passes.capi.cpp.inc -gen-pass-capi-impl --prefix ArmSME)
mlir_tablegen(PassesEnums.h.inc -gen-enum-decls)
mlir_tablegen(PassesEnums.cpp.inc -gen-enum-defs)
add_public_tablegen_target(MLIRArmSMETransformsIncGen)
add_dependencies(mlir-headers MLIRArmSMETransformsIncGen)

add_mlir_doc(Passes ArmSMEPasses ./ -gen-pass-doc)
```


https://github.com/llvm/llvm-project/pull/82190