[Mlir-commits] [mlir] [mlir][vector] Group re-order patterns together (PR #102856)

[llvmlistbot at llvm.org]

================
@@ -2030,8 +2030,7 @@ void mlir::vector::populateVectorContractCanonicalizeMatmulToMMT(
 void mlir::vector::populateVectorReductionToContractPatterns(
     RewritePatternSet &patterns, PatternBenefit benefit) {
   patterns.add<MultiReduceToContract, CombineContractBroadcast,
-               CombineContractABTranspose, CombineContractResultTranspose,
-               ReorderCastOpsOnBroadcast, ReorderElementwiseOpsOnTranspose>(
----------------
MaheshRavishankar wrote:

Thanks for the heads up! So is the expectation that you run the sink before you run contract conversion patterns.

I agree the current grouping of patterns is adhoc, but what is the expected path for users (iree and others) to get back the same code that this one method would give?

https://github.com/llvm/llvm-project/pull/102856