[Mlir-commits] [mlir] Skip address space checks for memrefs between launchFuncOp and kernel func (PR #102925)

Fabian Mora llvmlistbot at llvm.org
Wed Aug 14 06:17:13 PDT 2024


fabianmcg wrote:

> for memory that is shared between host and device (the runtime controls the necessary transfers) the host memref should have address space zero as a regular memory buffer. It's not a gpu buffer, so the attribute doesn't make any sense.

My issue here is that you're changing the semantics of the op for a very particular case. The semantics of `gpu.launch_func` are similar to those of a `call` operation, where the signature is expected to be an exact match.

To me the correct solution is having a new operation for your runtime.

https://github.com/llvm/llvm-project/pull/102925


More information about the Mlir-commits mailing list