[Mlir-commits] [mlir] [MLIR] Let matchers work on int ranges (PR #102494)

Markus Böck llvmlistbot at llvm.org
Wed Aug 14 01:47:45 PDT 2024


https://github.com/zero9178 approved this pull request.

I think the way the PR discussion has been going to be right thing to do short-term. 
The way the speculation interface is being used is the way it was intended AFAIR. The interface lookup is also constant time and something that should be sped up in MLIR in general rather than being a blocker here IMO. 
What interface to use for the range analysis seems to be an ongoing issue since we now have I think 3 interfaces that roughly try to do range analysis in different scenarios so adding a 4th is definitely undesireable IMO. But at the same time the choice of the interface here shouldn't be a blocker. 

LGTM with the new names

https://github.com/llvm/llvm-project/pull/102494


More information about the Mlir-commits mailing list