[Mlir-commits] [mlir] [mlir][vector] Group tests for re-order patterns (PR #102856)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue Aug 13 09:45:19 PDT 2024


banach-space wrote:

@MacDue Thanks for the feedback! Having thought about it, I feel that grouping all "reorder"/"sink" patterns under one `populate_Patterns()` hook would make most sense. I decided to name it as `populateVectorSinkPatterns()` - it nicely conveys _why_ that you suggested documenting.

I've renamed all the relevant hooks, passes and flags. If you agree that this is the right direction, I'll update the summary and make this PR about patterns rather than tests (grouping tests would be a nice side-effect). At which point, I'll ping a downstream user (e.g. from IREE) to also approve this. How does it sound?

Btw, I think that the updated version addresses your comments?

https://github.com/llvm/llvm-project/pull/102856


More information about the Mlir-commits mailing list