[Mlir-commits] [mlir] [MLIR, LLVM]: Add an IR utility to perform proper slicing (PR #103053)

River Riddle llvmlistbot at llvm.org
Tue Aug 13 08:09:30 PDT 2024


River707 wrote:

> > I dont understand part of the description. Why is this in the IR library? The reasons for putting something in IR/ for mlir seem completely unrelated to llvm.
> 
> Sorry, I was referring to the LLVM dialect's inliner interface. It is part of MLIRLLVMDialect due to the dialect initializing all interfaces directly in its initialization function. As far as I can tell, a dialect library is not supposed to depend on MLIRAnalysis, so that's why I put the utility into MLIRIR.

Ah, I see, thanks for clarifying. I don't think that's a good case for putting something in IR/ though. I'd rather figure out the organizational structure outside of it, and keep the bar for growing IR (which impacts everything) high.

https://github.com/llvm/llvm-project/pull/103053


More information about the Mlir-commits mailing list