[Mlir-commits] [mlir] b7863d1 - [mlir] Fix misleading comment for type trait (#103041)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Aug 13 04:00:08 PDT 2024
Author: qazwsxedcrfvtg14
Date: 2024-08-13T13:00:03+02:00
New Revision: b7863d13df2ec51fe0966f2de011965c0322c8b6
URL: https://github.com/llvm/llvm-project/commit/b7863d13df2ec51fe0966f2de011965c0322c8b6
DIFF: https://github.com/llvm/llvm-project/commit/b7863d13df2ec51fe0966f2de011965c0322c8b6.diff
LOG: [mlir] Fix misleading comment for type trait (#103041)
We are using `has_initialize` to check the class has `initialize`
function instead of the `getOperationName` function.
Added:
Modified:
mlir/include/mlir/IR/PatternMatch.h
Removed:
################################################################################
diff --git a/mlir/include/mlir/IR/PatternMatch.h b/mlir/include/mlir/IR/PatternMatch.h
index ed7b9ece4a464..896fdf1c899e3 100644
--- a/mlir/include/mlir/IR/PatternMatch.h
+++ b/mlir/include/mlir/IR/PatternMatch.h
@@ -289,7 +289,7 @@ class RewritePattern : public Pattern {
using Pattern::Pattern;
private:
- /// Trait to check if T provides a `getOperationName` method.
+ /// Trait to check if T provides a `initialize` method.
template <typename T, typename... Args>
using has_initialize = decltype(std::declval<T>().initialize());
template <typename T>
More information about the Mlir-commits
mailing list