[Mlir-commits] [mlir] a9636b7 - [mlir][StorageUniquer] Restore old signature for default implementaion of verifyInvariants. (#103023)

[llvmlistbot at llvm.org]

Author: Benjamin Chetioui
Date: 2024-08-13T12:05:15+02:00
New Revision: a9636b7f60f283926c66e96c036f5b5d9e57c026

URL: https://github.com/llvm/llvm-project/commit/a9636b7f60f283926c66e96c036f5b5d9e57c026
DIFF: https://github.com/llvm/llvm-project/commit/a9636b7f60f283926c66e96c036f5b5d9e57c026.diff

LOG: [mlir][StorageUniquer] Restore old signature for default implementaion of verifyInvariants. (#103023)

PR #102326 changed the prototype of the default implementation of verify
to include emitErrorFn.

This breaks automatic derivation in consumer attributes, such as
https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53.

This PR simply restores the signature to what it was prior to PR
#102326.

Added: 
    

Modified: 
    mlir/include/mlir/IR/StorageUniquerSupport.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/StorageUniquerSupport.h b/mlir/include/mlir/IR/StorageUniquerSupport.h
index d6ccbbd8579947..2162a74a51580a 100644
--- a/mlir/include/mlir/IR/StorageUniquerSupport.h
+++ b/mlir/include/mlir/IR/StorageUniquerSupport.h
@@ -226,9 +226,7 @@ class StorageUserBase : public BaseT, public Traits<ConcreteT>... {
 
   /// Default implementation that just returns success.
   template <typename... Args>
-  static LogicalResult
-  verifyInvariants(function_ref<InFlightDiagnostic()> emitErrorFn,
-                   Args... args) {
+  static LogicalResult verifyInvariants(Args... args) {
     return success();
   }