[Mlir-commits] [mlir] [mlir][vector] Group tests for re-order patterns (PR #102856)

Benjamin Maxwell llvmlistbot at llvm.org
Tue Aug 13 02:58:25 PDT 2024


================
@@ -2049,6 +2048,12 @@ void mlir::vector::populateSinkVectorBroadcastPatterns(
       patterns.getContext(), benefit);
 }
 
+void mlir::vector::populateReoderVectorTransposePatterns(
+    RewritePatternSet &patterns, PatternBenefit benefit) {
+  patterns.add<ReorderElementwiseOpsOnTranspose>(patterns.getContext(),
+                                                 benefit);
+}
----------------
MacDue wrote:

This only adds a single pattern. Should `populateSinkVectorBroadcastPatterns()` and `populateReoderVectorTransposePatterns()` be separate things (they're not used separately here).

Why not just `populateVectorReoderPatterns()`? 
If you need more control you could still add options to the populate call.

https://github.com/llvm/llvm-project/pull/102856


More information about the Mlir-commits mailing list