[Mlir-commits] [mlir] [mlir] Handle attempted construction of invalid `AffineExpr` products (PR #103010)

[Felix Schneider]

ubfx wrote:

It seems like something like this should also be implemented for `%`, `floorDiv` and `ceilDiv`? Those are only valid (semi-)affine expressions if RHS is symbolic or constant.

However, I noticed that the tiling infrastructure (and maybe other places) use `%` and `floorDiv` with dim identifiers quite often, e.g. here:

https://github.com/llvm/llvm-project/blob/3c5509d9ad25ee49aa68ab0c60d73d9587635b62/mlir/lib/Dialect/Affine/Utils/Utils.cpp#L1827-L1836

https://github.com/llvm/llvm-project/pull/103010