[Mlir-commits] [clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

Daniil Fukalov llvmlistbot at llvm.org
Mon Aug 12 12:23:57 PDT 2024


dfukalov wrote:

> Could you try preprocessing each affected source file (i.e. compile it with -E) and see whether the total number of included source lines goes up or down? I think that would help to demonstrate whether this patch violates the "include as little as possible" philosophy.

The overall preprocessed files size for the whole lb/Support reduced from 257172 KB to 255369 KB (about 1%)

Anyway, I see the change is too big to review and discuss so I'm going to shrink it. I'm not sure is it better to update this PR or create a new one.

https://github.com/llvm/llvm-project/pull/102707


More information about the Mlir-commits mailing list