[Mlir-commits] [mlir] [MLIR][Support] A cache for cyclical replacers/maps (PR #98202)

[Ivan Butygin]

Hardcode84 wrote:

Unittest seems to be broken under the MSVC
```
FAILED: tools/mlir/unittests/Support/CMakeFiles/MLIRSupportTests.dir/CyclicReplacerCacheTest.cpp.obj
C:\PROGRA~2\MICROS~2\2022\BUILDT~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DGTEST_NO_LLVM_SUPPORT=0 -DMLIR_INCLUDE_TESTS -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -ID:\projs\llvm\llvm-build\tools\mlir\unittests\Support -ID:\projs\llvm\llvm-project\mlir\unittests\Support -ID:\projs\llvm\llvm-build\include -ID:\projs\llvm\llvm-project\llvm\include -ID:\projs\llvm\llvm-project\mlir\include -ID:\projs\llvm\llvm-build\tools\mlir\include -ID:\projs\llvm\llvm-project\third-party\unittest\googletest\include -ID:\projs\llvm\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -std:c++17 -MD  /EHs-c- /GR- -UNDEBUG /showIncludes /Fotools\mlir\unittests\Support\CMakeFiles\MLIRSupportTests.dir\CyclicReplacerCacheTest.cpp.obj /Fdtools\mlir\unittests\Support\CMakeFiles\MLIRSupportTests.dir\ /FS -c D:\projs\llvm\llvm-project\mlir\unittests\Support\CyclicReplacerCacheTest.cpp
D:\projs\llvm\llvm-project\mlir\unittests\Support\CyclicReplacerCacheTest.cpp(30): error C2326: 'auto CachedCyclicReplacerTest_testInPlaceRecursionPruneAnywhere_Test::TestBody::<lambda_1>::operator ()(int) const': function cannot access 'replacer'
```

```
Microsoft (R) C/C++ Optimizing Compiler Version 19.35.32216.1 for x64
```

CI passed, but looks like it uses older version
```
-- The C compiler identification is MSVC 19.29.30154.0
-- The CXX compiler identification is MSVC 19.29.30154.0
```

https://github.com/llvm/llvm-project/pull/98202