[Mlir-commits] [mlir] [mlir][Transforms] Add missing check in applyPermutation (PR #102099)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat Aug 10 23:26:37 PDT 2024


DarshanRamakant wrote:

> I maintain my original stance: when permutation is constant, verify doesn't require static shape. So I cant merge this for you. As for the test case you highlighted, I believe it would be more appropriate to modify it, such as by introducing perm as a parameter. And I don't think that's a good test, neither in terms of its style nor its test point design.

Aa suggested, I have removed the dynamic shape check, and modified the failing tests. 

https://github.com/llvm/llvm-project/pull/102099


More information about the Mlir-commits mailing list