[Mlir-commits] [mlir] [MLIR][DLTI][Transform] Introduce transform.dlti.query (PR #101561)
Rolf Morel
llvmlistbot at llvm.org
Fri Aug 9 10:41:34 PDT 2024
rolfmorel wrote:
Apologies all. I should have rebased locally before declaring the PR was ready to go. Lesson learned.
> The issue seems to be related to this change: #101119. "Existing DialectExtension subclasses will need a type ID to be registered for each subclass. "
Indeed, that commit introduced a change to how dialect extensions should be registered (the PR's title captures it well). I have it working locally now. Will submit another PR for a second go.
The change that I needed was:
```cpp
--- a/mlir/lib/Dialect/DLTI/TransformOps/DLTITransformOps.cpp
+++ b/mlir/lib/Dialect/DLTI/TransformOps/DLTITransformOps.cpp
@@ -75,6 +75,9 @@ class DLTITransformDialectExtension
: public transform::TransformDialectExtension<
DLTITransformDialectExtension> {
public:
+ MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID
+ (DLTITransformDialectExtension)
+
using Base::Base;
void init()
```
https://github.com/llvm/llvm-project/pull/101561
More information about the Mlir-commits
mailing list