[Mlir-commits] [mlir] [mlir][spirv] Add tests for `scf.while` and `scf.for` in `convert-to-spirv` pass (PR #102528)

Angel Zhang llvmlistbot at llvm.org
Fri Aug 9 07:41:38 PDT 2024


angelz913 wrote:

> Are these tested by the scf to spirv conversion? If yes, could we trim these tests down so that we don't duplicate tests?

Yes, these tests were mostly from the `scf-to-spirv` conversion. I just realized that I forgot to include them in the initial version PR, which made me think that `scf.while` and `scf.for` were not covered. To prevent duplicate tests, I can try to include tests that combine with memref (with storage class conversion that is not covered in `scf-to-spirv`).

https://github.com/llvm/llvm-project/pull/102528


More information about the Mlir-commits mailing list