[Mlir-commits] [mlir] [mlir][linalg] Exclude non-convolutional ops from isaConvolutionOpInterface (PR #102087)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Aug 8 22:39:03 PDT 2024
yifeizh2 wrote:
> I am not sure how useful such an operation would be given that `transform.match.structured.classify_convolution_dims` can already be used to do what `transform.match.structured.convolution_op_interface` would be able to do. It is up to you if you think such an operation would be useful. That also might be better as a separate PR.
I agree. The functionality of `transform.match.structured.convolution_op_interface` is a subset of `transform.match.structured.classify_convolution_dims`. Adding such an op does not have any practical use, which can only serve the purpose of adding unit test.
https://github.com/llvm/llvm-project/pull/102087
More information about the Mlir-commits
mailing list