[Mlir-commits] [mlir] [MLIR][Operation] Fix `isBeforeInBlock` crash bug mentioned in https://github.com/llvm/llvm-project/issues/60909 (PR #101172)

[llvmlistbot at llvm.org]

wang-y-z wrote:

> Sorry, didn't have the time to look at this PR until now. I don't think the solution here is the one we want. It'll be overly conservative and thrash the order of a block every time an operation gets added (which makes the dominance checks a lot more expensive when transformations happen). Can we instead just update `updateOrderIfNecessary` to support single operation blocks? There isn't really a good reason why I didn't do that originally and the code has changed a lot around it.

Thanks for pointing this from performance perspective, and I had a minor fix on `updateOrderIfNecessary`, please review it : )

https://github.com/llvm/llvm-project/pull/101172